Summary Table
Categories |
Total Count |
PII |
0 |
URL |
0 |
DNS |
0 |
EKL |
0 |
IP |
0 |
PORT |
0 |
VsID |
0 |
CF |
0 |
AI |
0 |
VPD |
0 |
PL |
0 |
Other |
0 |
File Content
for rfai-admin.component.html
This is a complex page. (Even ignoring the usual headers and navigation.)
In particular, it has 4 TABS, 8 ZIPS, 2 MESSAGES, 2 CONFIRM POPS, with many "hidden" parts.
Shorthand definitions:
TAB is a radio-button overlay for "index tabs".
ZIP: is an "accordion" that expands|hides when the label is clicked.
POP: is a modal pop-up dialog that presents a data entry form.
BTN: click to perform action
FOR: a table of rows
POP: <app-messages></app-messages> The idea is basically code-reuse. But it is a hodge-podge of different messages.
The basic idea is to use a boolean variable to show/hide the message. And the message is customized with a string value.
This requires that the variable be manipulated in the main component.
Special "animations" make the component automatically disappear.
But the caller can turn off using the status variable.
["Status" is too generic. A better name would be "xxxShow", not "xxxStatus".]
set of messages may pop up only two are used:
[errorStatus]="errorStatus" [errorMsg]="errorMsg"
[successStatus]="successStatus" [successMsg]="successMsg"
TAB: Manage Codes
ZIP: Health Care Claim Status Category Codes
BTN: Add New Code
POP: Add New Code
FOR: code in HCCSCC
BTN: Archive, Edit
BTN: Submit Changes
IF: any Archived
POP: Warning
BTN: Continue (submitCode)
BTN: Cancel (closeModal)
BTN: Reset
ZIP: LOINC Codes
BTN: Add New Code
POP: Add New Code
FOR: code in LOINC
BTN: Archive, Edit
BTN: Submit Changes
IF: any Archived
POP: Warning
BTN: Continue (submitCode)
BTN: Cancel (closeModal)
BTN: Reset
ZIP: LOINC Modifier Codes
BTN: Add New Code
POP: Add New Code
FOR: code in LOINC Modifier
BTN: Archive, Edit
BTN: Submit Changes
IF: any Archived
POP: Warning
BTN: Continue (submitCode)
BTN: Cancel (closeModal)
BTN: Reset
TAB: Notifications
ZIP: Submitted Email
Form: Heading, Email Message
BTN: Submit, Cancel
ZIP: Submission Error Email
Form: Heading, Email Message
BTN: Submit, Cancel
ZIP: Submission Abandoned Email
Form: Heading, Email Message
BTN: Submit, Cancel
ZIP: Submission Complete/Closed Email
Form: Heading, Email Message
BTN: Submit, Cancel
ZIP: Submission Manually Closed Email
Form: Heading, Email Message
BTN: Submit, Cancel
TAB: Payer Info
POP: Add New Payer
FOR: payer
BTN: Archive, Edit
BTN: Submit Changes
IF: any Archived
POP: Warning
BTN: Continue (submitPayer)
BTN: Cancel (closeModal)
BTN: Reset
TAB: Unarchiving (DRAFT)
ZIP: Attachments
FOR: Attachments (DRAFT)
ZIP: Health Care Claim Status Category Codes
BTN: Add New Code
POP: Add New Code
FOR: code in HCCSCC
BTN: Archive, Edit
BTN: Submit, Cancel
ZIP: LOINC Codes
BTN: Add New Code
POP: Add New Code
FOR: code in LOINC
BTN: Archive, Edit
BTN: Submit, Cancel
ZIP: LOINC Modifier Codes
BTN: Add New Code
POP: Add New Code
FOR: code in LOINC Modifier
BTN: Archive, Edit
BTN: Submit, Cancel
Because I had made some name changes, and new xxxTab() functions, and have not yet pushed code, The new "Unarchive" section came in without much to compare with. So I had to re-visit those name changes.
Summarizing: where /old/new/
modalClosed codeClosed // modalClosed was probably inherited, hence the generic name
payerModalClosed payerClosed // I found the "Modal" verbose
formModal codeForm
payerModalForm payerForm
onModalOpeCommon onCodeCommon // misspelled and generic
onModalClose onCodeClose
openAddPayerModal openAddPayer
openEditPayerModal openEditPayer
onPayerModalOpenCommon onPayerCommon
submitPayerInfo submitPayerForm // just personal preference?
resetPayerInfo resetPayerForm // just personal preference?
submit submitCodeForm // too generic
reset resetCodeForm // too generic
closeCofirmationModal closeConfirmationModal // spelling.
Actually, I preferred closeConfirmModel, but there was pressure from Philip Chiarato who complained about my making "personal" changes.
Since I have been getting Jim Adams' updates to rfai-admin, I've had to merge twice.
I think he may be making more changes.
If I restore some of the not-completely-bad names I can not generate so many changes.
OR I could push my changes, and let them do the merging.
TO be polite, I'm going to revert somewhat.
REVERT:
[tabIndex]="modalClosed?'0':'-1'" [tabindex]="codeTab" [tabindex]="tabindex" // is this simple, or confusing?
Regular expressions:
\((keydown|keyup)\) *= *"\$event\.keyCode *== *(13|Enter) *\? *([^:]+):''"
(keyup.enter)="\1"
modalClosed codeClosed codeModalClosed // modalClosed was probably inherited, hence the generic name
payerModalClosed payerClosed <= // I found the "Modal" verbose
formModal codeForm codeModalForm
payerModalForm payerForm <=
onModalClose onCodeClose onCodeModalClose
openAddPayerModal openAddPayer <=
openEditPayerModal openEditPayer <=
onPayerModalOpenCommon onPayerCommon <=
submitPayerInfo submitPayerForm <= // just personal preference?
resetPayerInfo resetPayerForm <= // just personal preference?
submit submitCodeForm submitCodeInfo // too generic
reset resetCodeForm resetCodeInfo // too generic
closeCofirmationModal closeConfirmationModal KEEP // spelling.
openAddModal openAddCode openAddCodeModal
openEditModal openEditCode openEditCodeModal
onPayerModalClose onPayerClose <=??
onModalOpenCommon onCodeCommon onCodeModalOpenCommon
addPayerClicked
addClicked addCodeClicked
addPayerClicked
modalClosedTab tabI // function is independent of use by modalClosed (codeModalClosed)
submitInfo
type confirmType
tabIndex tabindex // case sensitive
convenience functions to simplify html [src]= and [tabindex]= expressions
function empty(val) { return val === null || val === ''; } // null or empty string
function modalClosedTab(modalClosed: boolean) { return modalClosed ? '0' : '-1'; } // tabindex for modalClosed or not
// Handle logic for [tabindex]
// Also suppress tabindex while !confirmModalClosed
get codeTab() { return modalClosedTab(this.codeClosed && this.confirmModalClosed); }
get payerTab() { return modalClosedTab(this.payerClosed && this.confirmModalClosed); }
get modalTab() { return modalClosedTab(this.codeClosed && this.payerClosed); }
get tabindex() { return modalClosedTab(tabbable)
// handle [src]=
archSrc(archive) { return archive
? '../../assets/images/ic_archive_white_24.svg'
: '../../assets/images/ic_archive_red_24.svg'; }
editSrc(archive) { return archive
? '../../assets/images/ic_edit_table_white_24.svg'
: '../../assets/images/ic_edit_table_blue_24.svg'; }